Skip to content

Conversation

@narenr94
Copy link

@narenr94 narenr94 commented Aug 8, 2025

RDKEMW-6895 : RDKE player-interface meta layer changes
Reason for change : component separation of player-interface from aamp
Test Steps : Basic Regression
Risk : Low
Signed-off : Naren Ramesh [email protected]

@narenr94 narenr94 requested review from a team as code owners August 8, 2025 05:53
@CLAassistant
Copy link

CLAassistant commented Aug 8, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ ALSAMEEMA
✅ narenr94
✅ Nithya-k13
✅ TanujSharma369
❌ Tanuj


Tanuj seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI review requested due to automatic review settings October 29, 2025 02:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the new player-interface package to the middleware layer, including its configuration and source revision settings. The SRCREV for the aamp package is also updated.

  • Adds player-interface to the middleware packagegroup
  • Configures version and architecture settings for player-interface
  • Updates source revisions for player-interface and aamp

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
recipes-core/packagegroups/packagegroup-middleware-layer.bb Adds player-interface to the middleware RDEPENDS list
conf/include/generic-srcrev.inc Sets source revision for player-interface and updates aamp SRCREV
conf/include/generic-pkgrev.inc Configures package version, release, and architecture for player-interface

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 29, 2025 05:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 30, 2025 05:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 30, 2025 06:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 31, 2025 04:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 3, 2025 02:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 5, 2025 02:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 7, 2025 03:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +85 to +87
PV:pn-pn-player-interface = "1.0.0"
PR:pn-pn-player-interface = "r0"
PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}"
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name has a duplicated pn- prefix. It should be PV:pn-player-interface instead of PV:pn-pn-player-interface.

Suggested change
PV:pn-pn-player-interface = "1.0.0"
PR:pn-pn-player-interface = "r0"
PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}"
PV:pn-player-interface = "1.0.0"
PR:pn-player-interface = "r0"
PACKAGE_ARCH:pn-player-interface = "${MIDDLEWARE_ARCH}"

Copilot uses AI. Check for mistakes.
Comment on lines +85 to +87
PV:pn-pn-player-interface = "1.0.0"
PR:pn-pn-player-interface = "r0"
PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}"
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name has a duplicated pn- prefix. It should be PR:pn-player-interface instead of PR:pn-pn-player-interface.

Suggested change
PV:pn-pn-player-interface = "1.0.0"
PR:pn-pn-player-interface = "r0"
PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}"
PV:pn-player-interface = "1.0.0"
PR:pn-player-interface = "r0"
PACKAGE_ARCH:pn-player-interface = "${MIDDLEWARE_ARCH}"

Copilot uses AI. Check for mistakes.
Comment on lines +85 to +87
PV:pn-pn-player-interface = "1.0.0"
PR:pn-pn-player-interface = "r0"
PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}"
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name has a duplicated pn- prefix. It should be PACKAGE_ARCH:pn-player-interface instead of PACKAGE_ARCH:pn-pn-player-interface.

Suggested change
PV:pn-pn-player-interface = "1.0.0"
PR:pn-pn-player-interface = "r0"
PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}"
PV:pn-player-interface = "1.0.0"
PR:pn-player-interface = "r0"
PACKAGE_ARCH:pn-player-interface = "${MIDDLEWARE_ARCH}"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants