-
Notifications
You must be signed in to change notification settings - Fork 13
RDKEMW-6895 : RDKE player-interface meta layer changes #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
RDKEMW-4009: Add new AVI info frame APIs (#1130)
|
Tanuj seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the new player-interface package to the middleware layer, including its configuration and source revision settings. The SRCREV for the aamp package is also updated.
- Adds
player-interfaceto the middleware packagegroup - Configures version and architecture settings for
player-interface - Updates source revisions for
player-interfaceandaamp
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-middleware-layer.bb | Adds player-interface to the middleware RDEPENDS list |
| conf/include/generic-srcrev.inc | Sets source revision for player-interface and updates aamp SRCREV |
| conf/include/generic-pkgrev.inc | Configures package version, release, and architecture for player-interface |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PV:pn-pn-player-interface = "1.0.0" | ||
| PR:pn-pn-player-interface = "r0" | ||
| PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}" |
Copilot
AI
Nov 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name has a duplicated pn- prefix. It should be PV:pn-player-interface instead of PV:pn-pn-player-interface.
| PV:pn-pn-player-interface = "1.0.0" | |
| PR:pn-pn-player-interface = "r0" | |
| PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}" | |
| PV:pn-player-interface = "1.0.0" | |
| PR:pn-player-interface = "r0" | |
| PACKAGE_ARCH:pn-player-interface = "${MIDDLEWARE_ARCH}" |
| PV:pn-pn-player-interface = "1.0.0" | ||
| PR:pn-pn-player-interface = "r0" | ||
| PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}" |
Copilot
AI
Nov 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name has a duplicated pn- prefix. It should be PR:pn-player-interface instead of PR:pn-pn-player-interface.
| PV:pn-pn-player-interface = "1.0.0" | |
| PR:pn-pn-player-interface = "r0" | |
| PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}" | |
| PV:pn-player-interface = "1.0.0" | |
| PR:pn-player-interface = "r0" | |
| PACKAGE_ARCH:pn-player-interface = "${MIDDLEWARE_ARCH}" |
| PV:pn-pn-player-interface = "1.0.0" | ||
| PR:pn-pn-player-interface = "r0" | ||
| PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}" |
Copilot
AI
Nov 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name has a duplicated pn- prefix. It should be PACKAGE_ARCH:pn-player-interface instead of PACKAGE_ARCH:pn-pn-player-interface.
| PV:pn-pn-player-interface = "1.0.0" | |
| PR:pn-pn-player-interface = "r0" | |
| PACKAGE_ARCH:pn-pn-player-interface = "${MIDDLEWARE_ARCH}" | |
| PV:pn-player-interface = "1.0.0" | |
| PR:pn-player-interface = "r0" | |
| PACKAGE_ARCH:pn-player-interface = "${MIDDLEWARE_ARCH}" |
RDKEMW-6895 : RDKE player-interface meta layer changes
Reason for change : component separation of player-interface from aamp
Test Steps : Basic Regression
Risk : Low
Signed-off : Naren Ramesh [email protected]